LCDproc development and user support list

Text archives Help


[Lcdproc] Bug fix for ring and checkbox menu items


Chronological Thread 
  • From: martin at brasskipper.org.uk (Martin T Jones)
  • Subject: [Lcdproc] Bug fix for ring and checkbox menu items
  • Date: Fri, 28 Dec 2012 22:19:53 +0000

On 27/12/12 17:22, Markus Dolze wrote:
> Am 26.12.2012 22:44, schrieb Martin T Jones:
>> Hello,
>>
>> I hope everyone had a merry Christmas.
>>
>> I have attached a patch to fix a problem when using the left key to
>> change the ring and checkbox menu items. The old code used
>> modulus which does not give the required result, for C (ISO 1990) and
>> before the result is implementation defined so may have worked for
>> some compilers / targets but from C (ISO 1999) onwards the sign of
>> the result comes from the dividend so will not work.
>>
>> Happy New Year
>>
>> Martin
>
> Committed, thank you.
>
> How have you spotted this? That code is rather old already.
>
> Regards,
> Markus
>
> _______________________________________________
> LCDproc mailing list
> LCDproc at lists.omnipotent.net
> http://lists.omnipotent.net/mailman/listinfo/lcdproc
I was experimenting with the ring menu item and noticed the
left key did not wrap as it should, it was not difficult to find
when I knew what to look for. I guess that it is not used very
often.

Martin




Archive powered by MHonArc 2.6.18.

Top of page