LCDproc development and user support list

Text archives Help


[Lcdproc] Bug fix for ring and checkbox menu items


Chronological Thread 
  • From: bsdfan at nurfuerspam.de (Markus Dolze)
  • Subject: [Lcdproc] Bug fix for ring and checkbox menu items
  • Date: Thu, 27 Dec 2012 18:22:33 +0100

Am 26.12.2012 22:44, schrieb Martin T Jones:
> Hello,
>
> I hope everyone had a merry Christmas.
>
> I have attached a patch to fix a problem when using the left key to
> change the ring and checkbox menu items. The old code used
> modulus which does not give the required result, for C (ISO 1990) and
> before the result is implementation defined so may have worked for
> some compilers / targets but from C (ISO 1999) onwards the sign of the
> result comes from the dividend so will not work.
>
> Happy New Year
>
> Martin

Committed, thank you.

How have you spotted this? That code is rather old already.

Regards,
Markus





Archive powered by MHonArc 2.6.18.

Top of page