LCDproc development and user support list

Text archives Help


[Lcdproc] example menu?


Chronological Thread 
  • From: kripton AT kripserver.net (Jannis Achstetter)
  • Subject: [Lcdproc] example menu?
  • Date: Sat Jul 8 18:17:02 2006

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Peter Marschall schrieb:
> [...]
>> }
>> which doesn't make much sense (because it's always true (greater than
>> -20000 and smaller than 20000).
>> I fixed it to:
>> if (((js.value > -20000) && (js.value < 20000)) || (js.number >= 2 *
>> p->axes)) {
>> return NULL;
>> }
>>
>> and now the axis work. I don't know wether it has been fixed in CVS (I
>> used 0.5.0) but if not please fix it (file server/drivers/joy.c)
>
> thanks for the report and the patch.
> I committed it to CVS (stable as well as MAIN).
>
> Thanks
> Peter
Thanks for committing the fix, I looked at it with the web-based
CVS-viewer.
I saw you changed the line to:

*if* ((js.value > -20000) && (js.value < 20000) || (js.number >= 2 *
p->axes))

The code that I used is:

if (((js.value > -20000) && (js.value < 20000)) || (js.number >= 2 *
p->axes))

I'm not sure how C handles the different expressions but my solution
sounds more logical to me. I don't say the line you committed is
wrong, honestly I just don't know. Maybe it's just a little mistake
and you forgot the braces.

Greetings,
Jannis Achstetter
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.4 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEr/ZgeYlewm37lbgRAsw3AJ43jYqCTUjeRr8W33KD2jEBLjtd/ACdH86d
SL/xON8v2/9oVBjqMnYMdoE=
=h6hy
-----END PGP SIGNATURE-----





Archive powered by MHonArc 2.6.18.

Top of page