LCDproc development and user support list

Text archives Help


[Lcdproc] [PATCH] MtxOrb.c for both 0.4.5 & 0.5


Chronological Thread 
  • From: lcdproc AT neko.me.uk (Chris Lansley)
  • Subject: [Lcdproc] [PATCH] MtxOrb.c for both 0.4.5 & 0.5
  • Date: Wed Sep 15 19:29:01 2004

I feel we're getting a bit off topic - so I'll just thank you
again for your feed back on my patch.


Any one else have comments? I'm going to give it another 24 hours
(unless somebody objects) for further feed back and then commit the
change if there is none. Then I will start getting the other patches
ready for submitting to this list.

Chris.

> -----Original Message-----
> From: Joris Robijn
> [mailto:joris AT robijn.net]
> Sent: 15 September 2004 20:19
> To: Chris Lansley
> Cc: LCDproc
> Subject: RE: [Lcdproc] [PATCH] MtxOrb.c for both 0.4.5 & 0.5
>=20
>=20
> On 15 Sep 2004 at 20:06, Chris Lansley wrote:
>=20
> >=20
> > I'm fully aware of the comments in the configfile.h file -=20
> but this kind
> > of
> > interface is still asking for trouble, 1st because not everyone=20
> will look
> > at those comments, and 2nd (based on the code I've seen) not=20
> every one who
> > makes changes is a skilled programmer.
>=20
> Every scheme has its own trouble. At least this leaves the =
responsibility=20
> for cleaning up the string to the same file that allocated the string. =

> That's a good principle.=20
>=20
> There have been enough trouble with programs that allocate space at =
place=20
> X and don't deallocate it, or do that twice (resulting in a =
deallocation=20
> of a different string that was much more recently allocated by an =
unknown=20
> function and accidently resided at the same memory location)
>=20
> Of course feeding a buffer and a maximum size to the config_* =
functions=20
> would have been safe too, but then you have a limitation in size and a =

> less elegant function prototype.
>=20
> Joris
> --
> Joris Robijn
> <joris AT robijn.net>
> Mobile: +31 6 288 41 964
>=20
> // To understand recursion, we must first understand=20
> recursion
>=20
>=20







Archive powered by MHonArc 2.6.18.

Top of page