LCDproc development and user support list

Text archives Help


[Lcdproc] [PATCH] MtxOrb.c for both 0.4.5 & 0.5


Chronological Thread 
  • From: lcdproc AT neko.me.uk (Chris Lansley)
  • Subject: [Lcdproc] [PATCH] MtxOrb.c for both 0.4.5 & 0.5
  • Date: Wed Sep 15 19:07:02 2004

Hi Joris,

> > I must say I don't like that config function - it might be=20
> > worth adding a comment next to every call just in case!
>=20
> You should never simply propagate a string from a config_* function to =
a=20
> calling function. If you want to own a string resulting from a config=20
> function you should strdup() the returned string, or copy it or=20
> something. Read the comments in the configfile.h file for more info.

I'm fully aware of the comments in the configfile.h file - but this =
kind of
interface is still asking for trouble, 1st because not everyone will =
look at
those comments, and 2nd (based on the code I've seen) not every one who =
makes
changes is a skilled programmer.

Chris.







Archive powered by MHonArc 2.6.18.

Top of page