LCDproc development and user support list

Text archives Help


[Lcdproc] Some minor autoconf/automake issues


Chronological Thread 
  • From: christian.grigis AT smartdata.ch (Christian Grigis)
  • Subject: [Lcdproc] Some minor autoconf/automake issues
  • Date: Fri Jul 25 14:20:02 2003

Hello,

I have recently downloaded the CVS version of lcdproc, and noticed a
few issues with the autoconf/automake files that would prevent me from
fully configuring and building the software from a directory different
that the top one (needing to cross-compile for various platforms helps
in spotting those :) ).

As I imagine it can be useful in general, I am attaching here a small
patch with the changes I needed. The issues addressed are:

- missing $srcdir or $top_srcdir in include paths for a couple makefiles
- missing ${srcdir} in a compile test in configure.in
- typo in acinclude.m4 macro
- missing link flags to build LCDd, which (for me at least) resulted in
not being able to load a driver (stv5730) that uses get_args()

Hope this is useful, and a big thanks to all the people involved in this
great piece of software!

Best regards,

-Christian
--
Christian Grigis | SMARTDATA SA
Software Engineer | PSE-B / EPFL
Phone: +41-21-693-84-98 | CH - 1015 Lausanne
mailto:christian.grigis AT smartdata.ch
| http://www.smartdata.ch


diff -Naur lcdproc-CVS-current-20030716.original/server/commands/Makefile.am
lcdproc-CVS-current-20030716/server/commands/Makefile.am
--- lcdproc-CVS-current-20030716.original/server/commands/Makefile.am
2002-04-26 02:12:38.000000000 +0200
+++ lcdproc-CVS-current-20030716/server/commands/Makefile.am 2003-07-16
13:41:02.000000000 +0200
@@ -1,3 +1,3 @@
noinst_LIBRARIES = libLCDcommands.a
libLCDcommands_a_SOURCES = command_list.c command_list.h client_commands.c
client_commands.h menu_commands.c menu_commands.h screen_commands.c
screen_commands.h server_commands.c server_commands.h widget_commands.c
widget_commands.h
-INCLUDES = -I$(top_srcdir) -I..
+INCLUDES = -I$(top_srcdir) -I$(srcdir)/..
diff -Naur lcdproc-CVS-current-20030716.original/shared/Makefile.am
lcdproc-CVS-current-20030716/shared/Makefile.am
--- lcdproc-CVS-current-20030716.original/shared/Makefile.am 2002-06-29
18:37:19.000000000 +0200
+++ lcdproc-CVS-current-20030716/shared/Makefile.am 2003-07-16
13:39:50.000000000 +0200
@@ -1,2 +1,3 @@
noinst_LIBRARIES = libLCDstuff.a
libLCDstuff_a_SOURCES = LL.c LL.h sockets.c sockets.h str.c str.h
configfile.c configfile.h debug.h report.c report.h snprintf.c snprintf.h
+INCLUDES = -I$(top_srcdir)
--- lcdproc-CVS-current-20030716.original/configure.in 2003-07-16
09:00:38.000000000 +0200
+++ lcdproc-CVS-current-20030716/configure.in 2003-07-16 14:01:20.000000000
+0200
@@ -120,7 +120,7 @@
dnl Check if we support this parallel (LPT) port
dnl IMPORTANT: we must do all the checks used in port.h before doing this
test!
AC_CACHE_CHECK([for a parallel port], ac_cv_port_have_lpt,
-[AC_TRY_COMPILE([#include "server/drivers/port.h"], [char val =
port_in(0x350)], ac_cv_port_have_lpt=yes, ac_cv_port_have_lpt=no)])
+[AC_TRY_COMPILE([#include "${srcdir}/server/drivers/port.h"], [char val =
port_in(0x350)], ac_cv_port_have_lpt=yes, ac_cv_port_have_lpt=no)])

if test "$ac_cv_port_have_lpt" = yes
then
--- lcdproc-CVS-current-20030716.original/acinclude.m4 2003-06-04
01:20:33.000000000 +0200
+++ lcdproc-CVS-current-20030716/acinclude.m4 2003-07-16 14:59:57.000000000
+0200
@@ -192,7 +192,7 @@
DRIVERS="$DRIVERS stv5730${SO}"
actdrivers=["$actdrivers stv5730"]
else
- AC_MSG_WARN([The sed1330 driver needs a
parallel port.])
+ AC_MSG_WARN([The stv5730 driver needs a
parallel port.])
fi
;;
svga)
diff -Naur lcdproc-CVS-current-20030716.patch.autofiles/server/Makefile.am
lcdproc-CVS-current-20030716/server/Makefile.am
--- lcdproc-CVS-current-20030716.patch.autofiles/server/Makefile.am
2002-06-29 18:37:19.000000000 +0200
+++ lcdproc-CVS-current-20030716/server/Makefile.am 2003-07-21
11:37:33.000000000 +0200
@@ -2,4 +2,6 @@
sbin_PROGRAMS=LCDd
LCDd_SOURCES= client.c client.h clients.c clients.h input.c input.h main.c
main.h menuitem.c menuitem.h menu.c menu.h menuscreens.c menuscreens.h
parse.c parse.h render.c render.h screen.c screen.h screenlist.c screenlist.h
serverscreens.c serverscreens.h sock.c sock.h widget.c widget.h drivers.c
drivers.h driver.c driver.h
LCDd_LDADD = ../shared/libLCDstuff.a commands/libLCDcommands.a
+LCDd_LDFLAGS = -rdynamic -uget_args
+
INCLUDES = -I$(top_srcdir)


  • [Lcdproc] Some minor autoconf/automake issues, Christian Grigis, 07/25/2003

Archive powered by MHonArc 2.6.18.

Top of page