LCDproc development and user support list

Text archives Help


[Lcdproc] UPDATE: MTC-S16209x driver


Chronological Thread 
  • From: michael.boman AT securecirt.com (Michael Boman)
  • Subject: [Lcdproc] UPDATE: MTC-S16209x driver
  • Date: Sat Sep 28 13:32:01 2002

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Saturday 28 September 2002 09:01, Guillaume Filion wrote:
> At 07:41 +0800 28/09/02, Michael Boman wrote:
> >On Saturday 28 September 2002 06:51, Guillaume Filion wrote:
> >> At 06:05 +0800 28/09/02, Michael Boman wrote:
> >> >The PDF is about 777 Kb in size, and my patch is about 4.0 Kb..
> >> >Who can I send them to, if not the mailinglist?
> >>
> >> If it's that small, just send it to me and I'll put it on our
> >> website at lcdproc.sf.net.
> >
> >Here you are!
>
> Here is it: http://lcdproc.sf.net/docs/datasheets/MTC-16209A.pdf
> I also put a link on http://lcdproc.sf.net/docs

Thanks!

> >BTW: I haven't any of the LCD's here at this moment (my
> >demo/devel box went out for a demo ;-) ), so I am not 100% sure that
> >the LCD still works... it does compile OK thought..
>
> I also added your driver (mtc_s16209x) to the CVS tree. No one is
> responsible for adding drivers, so very often we forget about it...
> (shame) So to others who provided patches that didn't get commited,
> please nag us more. 8)

Thanks again!

> BTW, I get these warnings when compiling on my RedHat 7.2 box
> (gcc-2.96 ; glibc-2.2.4):
> gcc -DHAVE_CONFIG_H -I. -I. -I../.. -I../.. -Wall -O3 -c
> mtc_s16209x.c
> mtc_s16209x.c: In function `MTC_S16209X_init':
> mtc_s16209x.c:152: warning: unused variable `reboot'
> mtc_s16209x.c:151: warning: unused variable `tmp'
> mtc_s16209x.c: At top level:
> mtc_s16209x.c:132: warning: `MTC_S16209X_hidecursor' declared
> `static' but never defined
> No biggie, but your compiler may not tell you about it.

Fixed, see attached patch.

BTW: Could I have access to update my driver on CVS? My sf.net account name
is
'mboman'.

Best regards
Michael Boman

- --
Michael Boman
Security Architect, SecureCiRT (A SBU of Z-Vance Pte Ltd)
http://www.securecirt.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE9la8mds5fQJiraJwRAktYAJ0SV/2NIftl1JSK2OvBYARBOrMPAgCgnP7G
DRxI/zrDmvXWcMzQdXxbw00=
=BEl+
-----END PGP SIGNATURE-----
Index: server/drivers/mtc_s16209x.c
===================================================================
RCS file: /cvsroot/lcdproc/lcdproc/server/drivers/mtc_s16209x.c,v
retrieving revision 1.1
diff -u -3 -r1.1 mtc_s16209x.c
--- server/drivers/mtc_s16209x.c	28 Sep 2002 00:57:35 -0000	1.1
+++ server/drivers/mtc_s16209x.c	28 Sep 2002 13:27:41 -0000
@@ -33,6 +33,9 @@
  * The LCD is optional front panel for Gigabyte GS-SR104 system from
  * Gigabyte (http://www.gigabyte.com.tw)
  *
+ * Any other implementations are not known. Please let me know if you
+ * have encountered any other implementations.
+ *
  */
 
 #include <stdlib.h>
@@ -66,9 +69,9 @@
 
 char lcd_changeline[] = "\xFE\xC0";	// From CHLine()
 
-char lcd_setcursor[] = "\xFE\xC0";	// From Set_Cursor(). Add location to second byte
-char lcd_setcursor_1[] = "\xFE\x80";	// First 16 bytes, add location to second byte. From Set_Cursor1()
-char lcd_setcursor_2[] = "\xFE\xB0";	// Second 16 bytes (17-32), add location to second byte. From Set_Cursor1()
+char lcd_setcursor[] = "\xFE\xC0";	// From Set_Cursor(). Add location to second byte [lcd_setcursor[1] + loc]
+char lcd_setcursor_1[] = "\xFE\x80";	// First 16 bytes, add location to second byte. From Set_Cursor1() [lcd_setcursor_1[1] + loc]
+char lcd_setcursor_2[] = "\xFE\xB0";	// Second 16 bytes (17-32), add location to second byte. From Set_Cursor1() [lcd_setcursor_2[1] + loc]
 
 char lcd_gotoline1[] = "\xFE\x80";	// First character on the first row
 char lcd_gotoline2[] = "\xFE\xC0";	// First character on the second row
@@ -129,7 +132,7 @@
 static int cellwidth = LCD_DEFAULT_CELLWIDTH;
 static int cellheight = LCD_DEFAULT_CELLHEIGHT;
 
-static void MTC_S16209X_hidecursor ();
+//static void MTC_S16209X_hidecursor ();
 static void MTC_S16209X_reboot ();
 
 // Vars for the server core
@@ -148,12 +151,15 @@
   int argc;
   struct termios portset;
   int i;
-  int tmp;
+
+#ifdef CAN_REBOOT_LCD
   int reboot = 0;
+#endif // CAN_REBOOT_LCD
 
   char device[256] = "/dev/lcd";
 
 #ifdef CAN_CONTROL_BACKLIGHT
+  int tmp;
   int backlight_brightness = 255;
 #endif // CAN_CONTROL_BACKLIGHT
 



Archive powered by MHonArc 2.6.18.

Top of page